Talk:ROSE Compiler Framework/Code Review

things to be improved/discussed
We have identified some potential improvements to the workflow documented on the default page

disallow direct push to central repo
We should make a decision about this soon. Since uncontrolled push to a git repo will result in some garbage stuck in our history forever.

prevent unauthorized pull request approval
prevent users from pushing/merging things to their own master. I know it can be difficult.

An alternative is to ask developers to initiate a pull request to be merged into reviewer's master branch. Then we can better control who can merge things. But then Jenkins should figure out whose commits are being actually tested.

Done: improve the auto sync job
2. improve the auto synch job to force synchronization, or at least report abnormal situations to admin and relevant users.

give freedom to create branches to be reviewed
The 2nd version of the workflow has a single dedicated branch in central repo to accept pushes.

This may not be desired since developers often work on multiple tasks and may push multiple things. A single accepting branch may become a bottleneck.

rose-compiler/rose and its fork
TODO: for the new, clean Github installation, we shouldn't fork rose-compiler/rose. Instead, we should create a new (mirror) of ROSE to each developer's account. This way, they can't accidentally open a pull request to rose-compiler/rose. However, we should still maintain rose-compiler/rose as our central repository.


 * Justin, I don't know why rose-compiler/rose is still needed. It would be a trap for users to click fork to fork from it. --Liao (discuss • contribs) 22:29, 18 July 2012 (UTC)

lose track of repos to be reviewed
I have found that I cannot easily know which repos should be reviewed. Email notifications are scattered in my email box. github.llnl.gov does not have a centralized place where I can see all pending reviews assigned to me. It does have tens of notifications but again hard to read.

This can be a problem since forgetting review something will cause delay. --Liao (discuss • contribs) 00:09, 19 July 2012 (UTC)